Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9347: Fixed select preview issue in form builder #5915

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Nov 19, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9347

Description

Issue: In form builder mode, when a select component with a URL data source and a default value is saved, it stores selectData. After saving, the select component also saves global metadata for this component. Consequently, any further changes to the default value will use the select data from the metadata instead of the new select component configuration.

Solution: Reset the submission value for the webform in the form builder during the rebuild process. This ensures that the metadata is empty, allowing the select component to reassign it with the new component configuration and show the correct component preview.

How has this PR been tested?

Unit and manual testing

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit 01ac3c7 into master Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants